WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] RE: kernel panic when enable x2apic

To: Weidong Han <weidong.han@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] RE: kernel panic when enable x2apic
From: Keir Fraser <keir@xxxxxxx>
Date: Tue, 30 Nov 2010 11:40:55 +0000
Cc: "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>, Sander Eikelenboom <linux@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 30 Nov 2010 03:42:09 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=S4b/eCAN4FqY7Fyjpa6bZuo2R1912u2B7AhFFkRhDhc=; b=P7DdXjGAN3m0SzvPuIPpKqC9qATiGWoU+EPdqdjFrM4YAhtml89Of+QFMwOmNz7mAD R9qLozcFV1VP0L7Tes6fgoUYRTOkjJutnd7MYoWaISWSUbkB/BukyQjr2DkWxQLF7jzS duF635NcjyWq30yLN+cEWJaiO516+3iOqzmLk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=tCIt3TSVnHH8fpXi83SkRQIn98InipWVuC7AVJPLu2O1F8t5VGzj1IA3UZJzea13Lw ahtTsbmIRr7sUnWQKL2pBTA6XMIFpCC0R9ng3/a/fnbR25SxWwIZ8QusLrEYbLcHZxdh ET/6Cl791m3J0VPZmj/mfEUbdGLrdq2LAkmpA=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C91A7328.B7B1%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuQcE1uByFqnXV9HkW/W3iuOS4idwAEyVJG
Thread-topic: [Xen-devel] RE: kernel panic when enable x2apic
User-agent: Microsoft-Entourage/12.27.0.100910
On 30/11/2010 09:23, "Keir Fraser" <keir@xxxxxxx> wrote:

>> The obvious solution is to remove
>> boot_cpu_data.x86_capability[4] = cpuid_ecx(1) in start_vmx. It indeed
>> works with the change. I will send out the patch after more tests.
> 
> Yes, the write to x86_capability is totally unnecessary. There is a similar
> pointless one in SVM code -- in fact they don't even manage to write to the
> correct array element of x86_capability[]!
> 
> Removing both writes to x86_capability[] would be an appropriate fix for 4.0
> branch as well.

I applied a fix to xen-unstable and xen-4.0-testing. Eyeballing plus a quick
test convinces me it is absolutely fine. I credited you in the changeset
comment, I hope that's okay.

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel