WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] hvm passthru: Fix a xen-unstable crash

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] hvm passthru: Fix a xen-unstable crash
From: Wei Wang2 <wei.wang2@xxxxxxx>
Date: Mon, 29 Nov 2010 17:47:09 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
Delivery-date: Mon, 29 Nov 2010 08:49:50 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1011291547230.14723@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C9196DCE.B449%keir@xxxxxxx> <alpine.DEB.2.00.1011291547230.14723@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6 (enterprise 20070904.708012)
On Monday 29 November 2010 16:49:05 Stefano Stabellini wrote:
> On Mon, 29 Nov 2010, Keir Fraser wrote:
> > Stefano,
> >
> > Can you ack/nack this patch please.
>
> ack.
>
> I think we also need this:
>
>
> diff -r 79b71c77907b xen/arch/x86/physdev.c
> --- a/xen/arch/x86/physdev.c  Wed Nov 24 10:20:03 2010 +0000
> +++ b/xen/arch/x86/physdev.c  Mon Nov 29 15:26:03 2010 +0000
> @@ -236,7 +236,8 @@ static int physdev_unmap_pirq(struct phy
>          spin_lock(&d->event_lock);
>          ret = unmap_domain_pirq_emuirq(d, unmap->pirq);
>          spin_unlock(&d->event_lock);
> -        goto free_domain;
> +        if ( unmap->domid == DOMID_SELF || ret )
> +            goto free_domain;
>      }
>
>      ret = -EPERM;
>
>
> Wei, could you give it a try, in addition to your patch?
>
> Thanks,
>
> Stefano

Hi Stefano,
This patch works well together with my patch on our testing system. No more 
crashes.
Thanks,
Wei 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel