Re: [Xen-devel] [PATCH] xenalyze: Use types which have consistent sizes across 32- and 64-bit compiles

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Thu, Nov 25, 2010 at 11:22 AM, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
> At 11:17 +0000 on 25 Nov (1290683878), Olaf Hering wrote:
>> On Mon, Nov 22, George Dunlap wrote:
>>
>> > Always use [unsigned] long long for 64-bit, [unsigned] int for 32-bit.
>>
>> George,
>>
>> there are two unsigned long left in hvm_mmio_assist_process().
>> I think the sizeof(unsigned long) should be sizeof(unsigned int).
>
> Why not use the stdint.h explicit-width types?

Because using them with printf() is ugly and clunky?

I was thinking at some point I'd need to go over to using stdint
types, but was putting it off as I deemed it unpleasant.  However, if
simply not using "long" works for x32 and x64, I'm happy.  I'd
consider patches switching over to stdint.h, but I probably won't
write one myself unless there's a compelling reason to do so.

 -George

>
> Tim.
>
> --
> Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> Principal Software Engineer, Xen Platform Team
> Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel