WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH, v2] fix "xm block-detach 0 ..." for extended-I

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH, v2] fix "xm block-detach 0 ..." for extended-ID devices
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Wed, 24 Nov 2010 10:56:08 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Wed, 24 Nov 2010 09:59:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CED44F202000078000241E9@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4CED44F202000078000241E9@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.24 (X11/20100302)
Jan Beulich wrote:
> Simply taking stat()'s st_rdev doesn't work here, as the minor is
> split into two parts, the major is present, and the "extended" bit
> isn't set.
>
> Rather than fixing this in a way that would likely be OS-dependent,
> simply remove the access to the device file, and instead just parse
> the provided string (as is done e.g. for block-attach).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>
> --- a/tools/python/xen/util/blkif.py
> +++ b/tools/python/xen/util/blkif.py
> @@ -19,11 +19,6 @@ def blkdev_name_to_number(name):
>      devname = 'virtual-device'
>      devnum = None
>  
> -    try:
> -        return (devname, os.stat(n).st_rdev)
> -    except Exception, ex:
> -        pass
> -
>      scsi_major = [ 8, 65, 66, 67, 68, 69, 70, 71, 128, 129, 130, 131, 132, 
> 133, 134, 135 ]
>      if re.match( '/dev/sd[a-z]([1-9]|1[0-5])?$', n):
>          major = scsi_major[(ord(n[7:8]) - ord('a')) / 16]
>   

I just realized this is a hunk in one of our local patches :-(.

Acked-by: Jim Fehlig <jfehlig@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>