 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 10/13] Nested Virtualization: interrupts (svm spe
| To: | Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 10/13] Nested Virtualization: interrupts (svm specific) |
| From: | Keir Fraser <keir@xxxxxxx> |
| Date: | Tue, 16 Nov 2010 15:45:52 +0000 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Tue, 16 Nov 2010 07:46:37 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=FBhLxQK2se+aczsuRPW7IbsfKRCwky/H8W+BgLJzHDs=; b=U5MoFIT73w38GFa0iTTSdJFjIYnZqMXUo9U++PmX2iHG8UQu5pVcoQAlotSwq5cZl8 u2C2GAJchL4g1VqhzNqzUpr8urBcGvk9LzoWXudQQSRtJVT2YGEl3VvUJS1ZmVFO4u1p Y7WPa0TgaRZZCCRpDHdF5Cl1BErm6DqjeDOAo= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=m3d+B0pS/CPI0aucAdwIrF2Lqv0fdEy1rHK2f4+N0qxZCrITPNnEmLbOnFDoiRbvFM dcSoYrghN2qjd/FAtB58p2oV4yFqw5Ie9zkF/ZoFzFRkREmTYQq8fjnkuuEaN3/SS/dk xASVzeErP/JgZgAts56pDsnpUFbW5A/3XUV8Q= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20101116150645.GE25462@xxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcuFpVkI12GEf6TbyEe4Fi5f6Wi6TQ== |
| Thread-topic: | [Xen-devel] [PATCH 10/13] Nested Virtualization: interrupts (svm specific) |
| User-agent: | Microsoft-Entourage/12.27.0.100910 |
On 16/11/2010 15:06, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:
>> +static int
>> +nestedsvm_vcpu_clgi(struct vcpu *v)
>> +{
>> + struct nestedsvm *svm = &vcpu_nestedsvm(v);
>> +
>> + /* clear gif flag */
>> + svm->ns_gif = 0;
>> + local_event_delivery_disable(); /* mask events for PV drivers */
>
> This function, and the stgi one below, can only operate safely on
> current; if you want to keep the argument for performance then maybe
> ASSERT(v == current) for sanity.
I don't believe in the performance win. Functions which act correctly only
on current should not be passed a vcpu parameter.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Re: [Xen-devel] Balloon driver for Linux/HVM, Chu Rui |
|---|---|
| Next by Date: | Re: [Xen-devel] [RFC Patch] Support for making an E820 PCI hole in toolstack (xl + xm), Konrad Rzeszutek Wilk |
| Previous by Thread: | Re: [Xen-devel] [PATCH 10/13] Nested Virtualization: interrupts (svm specific), Tim Deegan |
| Next by Thread: | [Xen-devel] [PATCH 03/13] Nested Virtualization: function hooks, Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
