WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] linux-2.6.18/evtchn: clear secondary CPUs' cpu_e

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux-2.6.18/evtchn: clear secondary CPUs' cpu_evtchn_mask[] after restore
From: Keir Fraser <keir@xxxxxxx>
Date: Tue, 16 Nov 2010 07:42:10 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 15 Nov 2010 23:43:29 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=U+qxcdpvBmTgKXcmgimkVl3CXqm9nkX0oXK3mFzbJss=; b=odL7PhTTSI9cYlWJd65p94DcOcLviAmJMCiJHxSHZhZ90mo/BXIwrKD5RG/SBd0LG/ 3WO10kyr6KZ5SEeAaiDbWVn1YYrPf9YplRVzyTLeskvt6PR2JZsV0gJga2fRrLROUMZN G/RCk+LTTMqurdtOwkFCKeiQkrrJ6p3HXd+NI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=tKCpsdduecjDqQGzp0lbsy0XSqivq/+MfUkjPKlz8MpxzWazb/YgiGr2SPoeD6bgpF 20LQvcmHNvD0dTFF9bx1BBsWkie0a/AZCwtXvDtqPJDTfMTmH+N/F95Vl3xhRmlYgP+W SHMQaNdM8oGD7QuFUpFvBm0Bgm7rFDK18W9s0=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CE1DE23.9070002@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuFYcaSf3wceW2SYE2M85D3Yz4Mdw==
Thread-topic: [Xen-devel] [PATCH] linux-2.6.18/evtchn: clear secondary CPUs' cpu_evtchn_mask[] after restore
User-agent: Microsoft-Entourage/12.27.0.100910
On 16/11/2010 01:28, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

> On 11/15/2010 08:56 AM, Jan Beulich wrote:

>> memset(cpu_evtchn, 0, sizeof(cpu_evtchn));
>> - memset(cpu_evtchn_mask[0], ~0, sizeof(cpu_evtchn_mask[0]));
>> + for_each_possible_cpu(i)
>> +  memset(cpu_evtchn_mask[i], -!i, sizeof(cpu_evtchn_mask[i]));
> 
> -!i?  Really?  Golf-clap and all, but I think something a bit more
> explicit would be better ;)

I'm going to clarify that bit when I apply to 2.6.18. :-)

 -- Keir

>     J
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel