WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Fix format warning for drivers/xen/blktap/device.c for x

On Tue, 2010-11-09 at 06:19 -0500, Ian Campbell wrote:
> On Tue, 2010-11-02 at 13:50 +0000, Teck Choon Giam wrote:
> > From: Giam Teck Choon <giamteckchoon@xxxxxxxxx>
> > 
> > Fix compilation format warning in drivers/xen/blktap/device.c
> > 
> > drivers/xen/blktap/device.c: In function ‘blktap_device_create’:
> > drivers/xen/blktap/device.c:869: warning: format ‘%llu’ expects type
> > ‘long long unsigned int’, but argument 5 has type ‘sector_t’
> > drivers/xen/blktap/device.c: In function ‘blktap_device_debug’:
> > drivers/xen/blktap/device.c:898: warning: format ‘%llu’ expects type
> > ‘long long unsigned int’, but argument 4 has type ‘sector_t’
> > 
> > Signed-off-by: Giam Teck Choon <giamteckchoon@xxxxxxxxx>
> 
> Seems reasonable to me.

Sure.

Building without large device support is rarely asked for, but why not.

Daniel

> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> > ---
> >  drivers/xen/blktap/device.c |    6 ++++--
> >  1 files changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/xen/blktap/device.c b/drivers/xen/blktap/device.c
> > index e4fc23e..8f1d3a9 100644
> > --- a/drivers/xen/blktap/device.c
> > +++ b/drivers/xen/blktap/device.c
> > @@ -867,7 +867,8 @@ blktap_device_create(struct blktap *tap, struct
> > blktap_params *params)
> >     set_bit(BLKTAP_DEVICE, &tap->dev_inuse);
> > 
> >     dev_info(disk_to_dev(gd), "sector-size: %u capacity: %llu\n",
> > -            queue_logical_block_size(rq), get_capacity(gd));
> > +            queue_logical_block_size(rq),
> > +            (unsigned long long)get_capacity(gd));
> > 
> >     return 0;
> > 
> > @@ -895,7 +896,8 @@ blktap_device_debug(struct blktap *tap, char *buf,
> > size_t size)
> > 
> >     s += snprintf(s, end - s,
> >                   "disk capacity:%llu sector size:%u\n",
> > -                 get_capacity(disk), queue_logical_block_size(q));
> > +                 (unsigned long long)get_capacity(disk),
> > +                 queue_logical_block_size(q));
> > 
> >     s += snprintf(s, end - s,
> >                   "queue flags:%#lx plugged:%d stopped:%d empty:%d\n",
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel