WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] Adding back CPUID support for Xsave

To: Haitao Shan <maillists.shan@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] Adding back CPUID support for Xsave
From: Keir Fraser <keir@xxxxxxx>
Date: Tue, 09 Nov 2010 08:52:47 +0000
Cc:
Delivery-date: Tue, 09 Nov 2010 00:53:40 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=VAe6ZRNyWOZA2mzI5kGO+DuGmelNdFytGYlCqt4f33M=; b=ZopzePvrkubMoaXiiWL5ANvUQFOpxdtkXuWjbfsEz7qKJI6RPZaEKXO5EIplrEKif8 Lcy++oNxDkTV/hhpevlzUY/xt4ewGJ8Z+INBBgmPPy8vwGrGjZ9GbDHr/Uw3qeu7we4E M7xG8yW7IHNq4BKa8sa/xgFNW0FOO/IPsj1gY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=RMO6QxTwXsNVM3nFDiYhn7qFfjOTND6X9MWI2cbHRyhqpam8NJ515fEvIBcVqWuGcg SlkOYyWKB1VyTu+rjnJPxwu3qpAdXFmHPdkzUL8sc+7wtLP7g0s73azlegXTXTxlm690 mrIxZ7uIuLtlh4F6gswrmbg1cNG0VAmrWLjlw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTik4q5FutsTL4BGyT8sT2nBJ6CoHxcJBL3v4x7dd@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Act/63shgKEUbP26A0qRgoFjMmm6Dg==
Thread-topic: [Xen-devel] [Patch] Adding back CPUID support for Xsave
User-agent: Microsoft-Entourage/12.27.0.100910
Thanks, this looks better. I have some further questions however.

You appear to only be exposing XSAVE to PV guests -- Why is that?

Also, the patch passes the AVX feature unconditionally through to HVM guests
-- firstly, why only visible HVM guests; and secondly, should it not be
conditional on XSAVE support in the hypervisor (don't we need XSAVE to be
able to save/restore AVX state)?

 -- Keir

On 09/11/2010 02:31, "Haitao Shan" <maillists.shan@xxxxxxxxx> wrote:

> Hi, Keir,
> 
> This patch adds back the reverted CPUID support for XSAVE feature. Can
> you have a review?
> 
> Signed-off-by: Shan Haitao <haitao.shan@xxxxxxxxx>
> 
> Shan Haitao
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel