WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] X86: Prefer TSC-deadline timer in Xen

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] X86: Prefer TSC-deadline timer in Xen
From: Keir Fraser <keir@xxxxxxx>
Date: Thu, 28 Oct 2010 15:42:02 +0100
Cc: "Brown, Len" <len.brown@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Thu, 28 Oct 2010 07:42:57 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=NuW3Q0Fy96oEUIsXC5PyZKOz8IvxkAt9g/DHWpZV5ME=; b=h8QGxDot+LQ2tHTFbj+RRdKTyrjrPaTeJnT3Sg3sJAmxJ+2t82rfyBBztmwZ2HYuB+ X5/2bcao879QUCIvDmWvwR3MwIglNDEyVyKYM5KTKa/CwffvQmKwQpe30w8SFeh4XpsO bHUuZqB66DWCAu3cPSWb9k+A9Aw/pxDvvR9oE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=m4K1R5izPemxZ1RFxf9reofpABqjWgqhNWRkR1NJUTDzHAb24RiFhdgBTYwXYljzXt wC7bNnBApuvzYN4qNmsP9iVHL7ISqgmi5wHEyk6jsV1X3XSqHdD83zpfQ52azj56iZbR +UnCysZUi4Eq9k5MBEuaDBIqDqzlLx4nEZFPs=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101028142232.GB11016@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Act2rkhTPsjL5Xw19EeHmxsnnnUi/Q==
Thread-topic: [Xen-devel] [PATCH] X86: Prefer TSC-deadline timer in Xen
User-agent: Microsoft-Entourage/12.27.0.100910
On 28/10/2010 15:22, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:

>> I still want to keep them because __setup_APIC_LVTT() will be called
>> multiple times - the first call with tdt_enabled == false, and the
>> following calls with tdt_enabled == true.
> 
> Is that important?  If so, please add explanatory comments in the
> appropriate places, because it's not obvious that it's happening, or why.

Indeed, I often simplify patches when I merge them, and an apparently
redundant foo_enabled variable would be first to go.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel