WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] for xend init script and xend python script

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [PATCH] for xend init script and xend python script
From: ShaunR <mailinglists@xxxxxxxxxxxxxxxx>
Date: Tue, 26 Oct 2010 10:38:42 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 26 Oct 2010 10:39:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19655.13.392293.144506@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <i9spod$lfi$1@xxxxxxxxxxxxxxx> <19655.13.392293.144506@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4
On 10/26/2010 9:21 AM, Ian Jackson wrote:
> ShaunR writes ("[Xen-devel] [PATCH] for xend init script and xend python script"):
>> This patch does the following, hopefully it will be added to future
>> versions.
>>
>> * xend init script will now send SIGINT to xenconsoled when stop is
>> issued so that the xenconsoled daemon is also stopped (this is required
>> if the new options below are added to /etc/sysconfig/xend
>
> This is handled by a new "xencommons" script in xen-unstable
> I think ?

Actually looks like it, i didnt check unstable sorry.

>
>> * /etc/sysconfig/xend has additional these additional cosnole options
>> since the xend init script starts xenconsoled.
>>        XENCONSOLED_LOG=(none|guest|hv|all)
>>        XENCONSOLED_LOGDIR=PATH
>>        XENCONSOLED_TIMESTAMP=(none|guest|hv|all)
>>        XENCONSOLED_OVERFLOW=(discard|keep)
>>        XENCONSOLED_PIDFILE=PATH
>
> Perhaps it would be better to have a single XENCONSOLED_OPTIONS
> variable ?

I see in the new xencommons that there's a XENCONSOLED_ARGS env which could hold all this info and be set in /etc/sysconfig/xencommons but I'm worried about it being overwritten by some of the checks in the script.

 69         echo Starting xenconsoled...
70 test -z "$XENCONSOLED_TRACE" || XENCONSOLED_ARGS=" --log=$XENCONSOLED_TRACE"
 71         xenconsoled --pid-file=$XENCONSOLED_PIDFILE $XENCONSOLED_ARGS
 72         test -z "$XENBACKENDD_DEBUG" || XENBACKENDD_ARGS="-d"
 73         test "`uname`" != "NetBSD" || xenbackendd $XENBACKENDD_ARGS
 74 }


Either way works i guess, i like separate options because i think it's easier for people to write automated scripts against to ensure the options they want are enabled.

Thanks!

~Shaun


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel