Re: [Xen-devel] [PATCH] xen: do not unmask disabled IRQ on eoi.

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 22.10.10 at 15:57, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> 
>>> wrote:
> In none of these cases the evtchn would be masked for sure, so I'll have
> to test if the evtchn is masked and call move_masked_irq or
> move_native_irq accordingly.  I preferred to test the evtchn_mask
> directly as opposed to the irq flags because the test is easier to
> understand (we could arrive in eoi_pirq from both handle_edge_irq or
> handle_fasteoi_irq, the latter doesn't set IRQ_MASKED when masks
> an irq).

But you still didn't add and IRQ_DISABLED check around the call
to move_masked_irq() - do you have any particular reason not to?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel