Re: [Xen-devel] [PATCH] cpupools: Make interface more consistent

To:	George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] cpupools: Make interface more consistent
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Thu, 21 Oct 2010 07:38:09 +0200
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Wed, 20 Oct 2010 22:39:06 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1287639492; x=1319175492; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4CBFD1C1.9000801@xxxxxxxxxxxxxx>\|Date:=20 Thu,=2021=20Oct=202010=2007:38:09=20+0200\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20George=20Dunlap=20<george.dunlap@xxxxxxxxxxx om>\|CC:=20xen-devel@xxxxxxxxxxxxxxxxxxx\|Subject:=20Re:=20 [Xen-devel]=20[PATCH]=20cpupools:=20Make=20interface=20mo re=20consistent\|References:=20<b2725b65076e59547fbb.12875 89760@gdunlap-desktop>\|In-Reply-To:=20<b2725b65076e59547f bb.1287589760@gdunlap-desktop>\|Content-Transfer-Encoding: =207bit; bh=eT83gyYrSVSImf2N1pNVS7KAduuMHCR1YAcPT0MeNR8=; b=Ycrl5xNsjFwJ8bgaV6bTyumoW2AMVDYhGJgxYDBUHf7QDujd4Rl79Owr g6BFS/Oukh/wXlV8TwleBMJOj+3swoxOddzslcBoFnGxVbNv6EtFzYHbR ZABpND2mEo9zclq7ovv9ixKQWfFV4lPZTVbyFdayQcQimK356M80PzW5H Q+fYNShePdgqx4i/NX6Xec2k3Bv+y0ac96cUOwOqHlwGCLBZTiK23lyk1 2WXoZ+QdQuTzZ9v8qMOk/MXO9ArsT;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=ZdouFBg6t3PEGS689IVRqiANvkzYgnnN6qpug6PsKoCcnd9sEk8Wv7Bo MFF4vFRDER37KzNjosjcbrEQM3e5yni6IMzqApiUKqOVoCs+3QbzMAEOh e9eaRJ2iQ/RbW7tNS5Q+2pK9S26fXl/Fal1y+QPyGTT9sI+ikLBA0oio8 TUXQNpy+6L7wWuX4obsR56/GGg3np6+BWBP4MAFudryaTRFhLs+Ls+T6M IAwcFmGVF9Y8PiNtaSTvqIBtKbCIX;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<b2725b65076e59547fbb.1287589760@gdunlap-desktop>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<b2725b65076e59547fbb.1287589760@gdunlap-desktop>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100913 Iceowl/1.0b1 Icedove/3.0.7

On 10/20/10 17:49, George Dunlap wrote:

The current cpupools code interface is a bit inconsistent.  This
patch addresses this by making the interaction for each
vcpu in a pool look like this:

alloc_vdata() -- allocates and sets up vcpu data
insert_vcpu() -- the vcpu is ready to run in this pool
remove_vcpu() -- take the vcpu out of the pool
free_vdata()  -- delete allocated vcpu data

(Previously, remove_vcpu and free_vdata were combined into a "destroy
vcpu", and insert_vcpu was only called for idle vcpus.)

This also addresses a bug in credit2 which was caused by a misunderstanding
of the cpupools interface.

Signed-off-by: George Dunlap<george.dunlap@xxxxxxxxxxxxx>


Acked-by: juergen.gross@xxxxxxxxxxxxxx

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] cpupools: Make interface more consistent