| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH v4 03/10] xen: remap MSIs into pirqs when running
> > + rc = HYPERVISOR_physdev_op(PHYSDEVOP_map_pirq, &map_irq);
> > + if (rc) {
> > + printk(KERN_WARNING "xen map irq failed %d\n", rc);
> > +
> > + dynamic_irq_cleanup(irq);
>
> Looking at include/linux/irq.h, I see this commment:
> /*
> 330 * Dynamic irq helper functions. Obsolete. Use irq_alloc_desc* and
> 331 * irq_free_desc instead.
> 332 */
>
> So we should use irq_free_desc instead of dynamic_irq_cleanup.
> (fyi, I didn't realize this until I started pulling in the sparse_irq
> patchset).
I looked at the rest of the patches and they all look good to me. Fix
this above and you can stick
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
on all the patches.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH v4 00/10] xen: initial domain support, Stefano Stabellini
- [Xen-devel] [PATCH v4 01/10] xen: introduce XEN_DOM0 as a silent option, stefano . stabellini
- [Xen-devel] [PATCH v4 02/10] xen: remap GSIs as pirqs when running as initial domain, stefano . stabellini
- [Xen-devel] [PATCH v4 03/10] xen: remap MSIs into pirqs when running as initial domain, stefano . stabellini
- [Xen-devel] [PATCH v4 04/10] xen: map a dummy page for local apic and ioapic in xen_set_fixmap, stefano . stabellini
- [Xen-devel] [PATCH v4 05/10] xen: use vcpu_ops to setup cpu masks, stefano . stabellini
- [Xen-devel] [PATCH v4 06/10] xen: Initialize xenbus for dom0., stefano . stabellini
- [Xen-devel] [PATCH v4 07/10] xen: add the direct mapping area for ISA bus access, stefano . stabellini
- [Xen-devel] [PATCH v4 08/10] xen: use host E820 map for dom0, stefano . stabellini
- [Xen-devel] [PATCH v4 09/10] xen: make hvc_xen console work for dom0., stefano . stabellini
- [Xen-devel] [PATCH v4 10/10] xen: mask the MTRR feature from the cpuid, stefano . stabellini
- [Xen-devel] Re: [PATCH v4 00/10] xen: initial domain support, Greg KH
|
|
|
| |
|
Home