 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [PATCH]: msi: Mask out multi-function flag from PCI_HEADER_T
| To: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] [PATCH]: msi: Mask out multi-function flag from PCI_HEADER_TYPE in read_pci_mem_bar() |
| From: | Gianni Tedesco <gianni.tedesco@xxxxxxxxxx> |
| Date: | Mon, 18 Oct 2010 18:26:07 +0100 |
| Cc: | Sander Eikelenboom <linux@xxxxxxxxxxxxxx>, Bruce Edge <bruce.edge@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx> |
| Delivery-date: | Mon, 18 Oct 2010 10:27:04 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
This leads to an erroneous WARN_ON and possibly other side effects. It
seems to me that even multi-function devices ought to enjoy the
privilege of MSI-X capabilities.
Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
diff -r fc2242ac90e1 xen/arch/x86/msi.c
--- a/xen/arch/x86/msi.c Mon Oct 18 11:31:47 2010 +0100
+++ b/xen/arch/x86/msi.c Mon Oct 18 18:14:22 2010 +0100
@@ -527,7 +527,7 @@ static u64 read_pci_mem_bar(u8 bus, u8 s
u8 limit;
u32 addr;
- switch ( pci_conf_read8(bus, slot, func, PCI_HEADER_TYPE) )
+ switch ( pci_conf_read8(bus, slot, func, PCI_HEADER_TYPE) & 0x7f )
{
case PCI_HEADER_TYPE_NORMAL:
limit = 6;
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] RE: pvclock (PV and HVM) and vsyscall, Dan Magenheimer |
|---|---|
| Next by Date: | Re: [Xen-devel] Race in vlapic init_sipi tasklet, Keir Fraser |
| Previous by Thread: | [Xen-devel] Race in vlapic init_sipi tasklet, George Dunlap |
| Next by Thread: | [Xen-devel] Re: [PATCH]: msi: Mask out multi-function flag from PCI_HEADER_TYPE in read_pci_mem_bar(), Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
