xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] x86/msi: fix inverted masks in c/s 22182:68cc3c514a0

from [Jan Beulich]

[Permanent Link][Original]

To:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] x86/msi: fix inverted masks in c/s 22182:68cc3c514a0a
From:	"Jan Beulich" <JBeulich@xxxxxxxxxx>
Date:	Wed, 13 Oct 2010 15:36:06 +0100
Delivery-date:	Wed, 13 Oct 2010 07:36:54 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -549,14 +549,14 @@ static u64 read_pci_mem_bar(u8 bus, u8 s
         return 0;
     if ( (addr & PCI_BASE_ADDRESS_MEM_TYPE_MASK) == 
PCI_BASE_ADDRESS_MEM_TYPE_64 )
     {
-        addr &= ~PCI_BASE_ADDRESS_MEM_MASK;
+        addr &= PCI_BASE_ADDRESS_MEM_MASK;
         if ( ++bir >= limit )
             return 0;
         return addr |
                ((u64)pci_conf_read32(bus, slot, func,
                                      PCI_BASE_ADDRESS_0 + bir * 4) << 32);
     }
-    return addr & ~PCI_BASE_ADDRESS_MEM_MASK;
+    return addr & PCI_BASE_ADDRESS_MEM_MASK;
 }
 
 /**

x86-msix-protect-table-and-pba-fix.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86/msi: fix inverted masks in c/s 22182:68cc3c514a0a, Jan Beulich <=

Previous by Date:	[Xen-devel] missing set_gpfn_from_mfn in XENMEM_add_to_physmap/XENMAPSPACE_gmfn for xenpaging, Olaf Hering
Next by Date:	[Xen-devel] Re: xen dependant on pcpu 0 ?, Jan Beulich
Previous by Thread:	[Xen-devel] missing set_gpfn_from_mfn in XENMEM_add_to_physmap/XENMAPSPACE_gmfn for xenpaging, Olaf Hering
Next by Thread:	[Xen-devel] PCI devices remap from dom0 to domU with pv-ops kernel, Lin, Ray
Indexes:	[Date] [Thread] [Top] [All Lists]