| 
         
xen-devel
[Xen-devel] [PATCH 12/23] x86/PCI: Clean up pci_cache_line_size
 
| 
To:  | 
linux-kernel@xxxxxxxxxxxxxxx | 
 
| 
Subject:  | 
[Xen-devel] [PATCH 12/23] x86/PCI: Clean up pci_cache_line_size | 
 
| 
From:  | 
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> | 
 
| 
Date:  | 
Tue, 12 Oct 2010 11:44:20 -0400 | 
 
| 
Cc:  | 
Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx,	Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>,	Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, x86@xxxxxxxxxx,	Jan Beulich <JBeulich@xxxxxxxxxx>,	Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>,	Alex Nixon <alex.nixon@xxxxxxxxxx>,	Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>,	Alex Nixon <alex.nixon@xxxxxxxxxx> | 
 
| 
Delivery-date:  | 
Tue, 12 Oct 2010 09:01:53 -0700 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<1286898271-32018-1-git-send-email-konrad.wilk@xxxxxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<1286898271-32018-1-git-send-email-konrad.wilk@xxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
 
 
From: Alex Nixon <alex.nixon@xxxxxxxxxx>
Separate out x86 cache_line_size initialisation code into its own
function (so it can be shared by Xen later in this patch series)
[ Impact: cleanup ]
Signed-off-by: Alex Nixon <alex.nixon@xxxxxxxxxx>
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Reviewed-by: "H. Peter Anvin" <hpa@xxxxxxxxx>
Reviewed-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>
Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
Cc: x86@xxxxxxxxxx
---
 arch/x86/include/asm/pci_x86.h |    1 +
 arch/x86/pci/common.c          |   17 ++++++++++-------
 2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/arch/x86/include/asm/pci_x86.h b/arch/x86/include/asm/pci_x86.h
index 49c7219..7045267 100644
--- a/arch/x86/include/asm/pci_x86.h
+++ b/arch/x86/include/asm/pci_x86.h
@@ -47,6 +47,7 @@ enum pci_bf_sort_state {
 extern unsigned int pcibios_max_latency;
 
 void pcibios_resource_survey(void);
+void pcibios_set_cache_line_size(void);
 
 /* pci-pc.c */
 
diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
index a0772af..f7c8a39 100644
--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -421,16 +421,10 @@ struct pci_bus * __devinit pcibios_scan_root(int busnum)
 
        return bus;
 }
-
-int __init pcibios_init(void)
+void __init pcibios_set_cache_line_size(void)
 {
        struct cpuinfo_x86 *c = &boot_cpu_data;
 
-       if (!raw_pci_ops) {
-               printk(KERN_WARNING "PCI: System does not support PCI\n");
-               return 0;
-       }
-
        /*
         * Set PCI cacheline size to that of the CPU if the CPU has reported it.
         * (For older CPUs that don't support cpuid, we se it to 32 bytes
@@ -445,7 +439,16 @@ int __init pcibios_init(void)
                pci_dfl_cache_line_size = 32 >> 2;
                printk(KERN_DEBUG "PCI: Unknown cacheline size. Setting to 32 
bytes\n");
        }
+}
+
+int __init pcibios_init(void)
+{
+       if (!raw_pci_ops) {
+               printk(KERN_WARNING "PCI: System does not support PCI\n");
+               return 0;
+       }
 
+       pcibios_set_cache_line_size();
        pcibios_resource_survey();
 
        if (pci_bf_sort >= pci_force_bf)
-- 
1.7.0.4
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 |   
 
| <Prev in Thread] | 
Current Thread | 
[Next in Thread>
 |  
- [Xen-devel] [PATCH 13/23] x86/PCI: make sure _PAGE_IOMAP it set on	pci mappings, (continued)
- [Xen-devel] [PATCH 13/23] x86/PCI: make sure _PAGE_IOMAP it set on	pci mappings, Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 07/23] xen: set pirq name to something useful., Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 05/23] xen: identity map gsi->irqs, Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 08/23] xen: statically initialize	cpu_evtchn_mask_p, Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 04/23] x86/io_apic: add get_nr_irqs_gsi(), Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 21/23] xen/pci: Request ACS when Xen-SWIOTLB is	activated., Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 14/23] x86/PCI: Export pci_walk_bus function., Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 19/23] xenbus: prevent warnings on unhandled	enumeration values, Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 01/23] xen: Don't disable the I/O space, Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 12/23] x86/PCI: Clean up pci_cache_line_size,
Konrad Rzeszutek Wilk <=
 
- [Xen-devel] [PATCH 11/23] xen: fix shared irq device passthrough, Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 17/23] xen/x86/PCI: Add support for the Xen PCI	subsystem, Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 06/23] xen: dynamically allocate irq & event	structures, Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 09/23] xen: Find an unbound irq number in	reverse order (high to low)., Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 03/23] xen: implement pirq type event channels, Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 02/23] xen: define BIOVEC_PHYS_MERGEABLE(), Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 22/23] MAINTAINERS: Add myself for Xen PCI and	Xen SWIOTLB maintainer., Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 10/23] xen: Provide a variant of xen_poll_irq	with timeout., Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 23/23] swiotlb-xen: On x86-32 builts,	select SWIOTLB instead of depending on it., Konrad Rzeszutek Wilk
 
- [Xen-devel] [PATCH 15/23] msi: Introduce	default_[teardown|setup]_msi_irqs with fallback., Konrad Rzeszutek Wilk
 
 
 
 
 |  
  
 | 
    |