Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: comman

To:	Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and library changes
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Tue, 12 Oct 2010 12:43:58 +0200
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date:	Tue, 12 Oct 2010 03:44:55 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1286880241; x=1318416241; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4CB43BEE.1020205@xxxxxxxxxxxxxx>\|Date:=20 Tue,=2012=20Oct=202010=2012:43:58=20+0200\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20Ian=20Campbell=20<Ian.Campbell@xxxxxxxxxx> \|CC:=20Ian=20Jackson=20<Ian.Jackson@xxxxxxxxxxxxx>,=20=0D =0A=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@lists. xensource.com>,=0D=0A=20Jan=20Beulich=20<JBeulich@novell. com>\|Subject:=20Re:=20[Xen-devel]=20[PATCH=202=20of=203] =20support=20of=20cpupools=20in=20xl:=20commands=0D=0A=20 and=09library=20changes\|References:=20<patchbomb.12865369 82@nehalem1>=09<91397dcffead19270897.1286536984@nehalem1> =09<19636.12203.651041.734393@xxxxxxxxxxxxxxxxxxxxxxxx> =20<1286877571.2003.1739.camel@xxxxxxxxxxxxxxxxxxxxxx> \|In-Reply-To:=20<1286877571.2003.1739.camel@xxxxxxxxxxxxx ource.com>\|Content-Transfer-Encoding:=207bit; bh=H3rA+kynKmjLBP5OHI4UKedrW5yAuZZ1U+JLmqEWe2s=; b=GK/dPUpicldovCnh/0mb1vnJlKji0CDeVT7jOz8bqgAs3iXBRatKjcXO kFV6/2DtxcczKJTX1c7t6OxuplcIZUd34B2abauxsyT26F2CGduFV3rl+ QXPkTvriOeMUKBNXphUe1PFKxjrVpgRPARBMh8XkIRWNToccefZAnYsXy ghpn8tQG+cfCQxUQf+RXQ+NmDqcLkN3R/dpNySqtpjJaEzgy2kVOoSnau m4bP1E7qlsjiLza3AQ87YVUp2uxrm;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=cXms+ABrRN32f4B+DrVAfNrG8JhXk6xz7czZ+F3Hdu6vFd4HmnsvLTmx ZSwjS/JGx1GM/77ad/UDRTcxDzPdXbhxJA0B5804bftWgEDzW01GDfyQp 8Tdf9lLyetBaEt0ZPo6jQEdp4YANoSBQdIt4aMDnDLhR6wCVhMbmnGI7D uhh7Lk9xEV7KGZ4agTQyFii+zvoUPPd1FWHgJYW7AcCp41fUWvmq2HTHr I3WTYGceWdL862eVbg798okBng0mY;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1286877571.2003.1739.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<patchbomb.1286536982@nehalem1> <91397dcffead19270897.1286536984@nehalem1> <19636.12203.651041.734393@xxxxxxxxxxxxxxxxxxxxxxxx> <1286877571.2003.1739.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100913 Iceowl/1.0b1 Icedove/3.0.7

On 10/12/10 11:59, Ian Campbell wrote:

On Tue, 2010-10-12 at 10:51 +0100, Ian Jackson wrote:

Juergen Gross writes ("[Xen-devel] [PATCH 2 of 3] support of cpupools in xl: 
commands and library changes"):

tools/libxl/libxlu_cfg_l.c   |   30 --
tools/libxl/libxlu_cfg_l.h   |   18 -


I see you reran flex.  That's not wrong, but we shouldn't change these
files needlessly, and you didn't make any changes to the .l source
file, so when we apply this patch we should drop the changes to
*_l.[ch].

Renamed all cpu pool related names to *cpupool*


Is that really true in this patch ?  The function names and subcommand
names in xl are still all "pool-*" and "pool_*".


The subcommands names are the xm names, which I thought we needed to
keep for compatibility.

We could add both cpupool- and pool- variants and deprecate the later.
Or perhaps these commands are not widely used (at least from scripts and
whatnot) and we can just change the name.


I have no problems changing the names to cpupool-*.
Do you think we should change the names for xm, too? This move should be
ack'ed by Novell, as they have included the cpupool stuff in SLES11 SP1.
I don't know if there are other users than Fujitsu (and we could change quite
easily). An option would be to support both variants in xm and only cpupool-*
in xl. CC-ing Jan.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and l