WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and l

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and library changes
From: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Date: Wed, 6 Oct 2010 14:47:49 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 06 Oct 2010 06:48:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <baee85a244118f380808.1286286316@nehalem1>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <baee85a244118f380808.1286286316@nehalem1>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2010-10-05 at 14:45 +0100, Juergen Gross wrote:
> diff -r cfce8e755505 -r baee85a24411 tools/python/xen/lowlevel/xl/xl.c
> --- a/tools/python/xen/lowlevel/xl/xl.c Tue Oct 05 14:19:13 2010 +0200
> +++ b/tools/python/xen/lowlevel/xl/xl.c Tue Oct 05 15:26:24 2010 +0200
> @@ -208,6 +208,11 @@
>      return -1;
>  }
>  
> +int attrib__uint64_t_ptr_set(PyObject *v, uint64_t * *pptr)
> +{
> +    return -1;
> +}
> +
>  int attrib__libxl_cpumap_set(PyObject *v, libxl_cpumap *pptr)
>  {
>      return -1;
> @@ -254,6 +259,11 @@
>  }
>  
>  PyObject *attrib__libxl_cpuid_policy_list_get(libxl_cpuid_policy_list
> *pptr)
> +{
> +    return NULL;
> +}
> +
> +PyObject *attrib__uint64_t_ptr_get(uint64_t * *pptr)
>  {
>      return NULL;
>  }

Because of using Reference(Uint64) directly in the idl - the python
bindings autogenerate these type-marshalling functions. It's not quite
clear how these are supposed to be implemented in a generic way! :)

There ought to be a builtin type for this ala libxl_uuid and other types
to generate correct bindings.

The other chunk to libxltypes then becomes redundant but it's OK with me
I think.

NAK'd-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>