Re: [Xen-devel] Re: xen: PV on HVM: support PV spinlocks

On Sat, 2 Oct 2010, Josip Rodin wrote:
> Hi,
> 
> I was just reading
> http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commitdiff;h=a16a1a93b92ef09c4d759fc711c7f17b658176ec
> 
> And there's a chunk that says:
> 
> +static void xen_hvm_spinlock_init(void)
> +{
> +       if (!xen_have_vector_callback)
> +               return
> +       xen_init_lock_cpu(0);
> +       xen_init_spinlocks();
> +}
> 
> The return statement doesn't have a semicolon after it, so it will instead
> take xen_init_lock_cpu(0) as its argument, and the xen_init_spinlocks() call
> will never happen.
> 

Well spotted!!  I fixed this issue (and another spinlock initialization
problem I found after that) and force-pushed both 2.6.32-pvhvm
and 2.6.35-rc5-pvhvm-v7.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] Re: xen: PV on HVM: support PV spinlocks, Josip Rodin Re: [Xen-devel] Re: xen: PV on HVM: support PV spinlocks, Stefano Stabellini <=

Previous by Date:

[Xen-devel] [PATCH] libxl: remove console 0 backend directory from xenstore on devices destroy, Ian Campbell

Next by Date:

[Xen-devel] Suspend or kill a syscall in hypervisor, Carlo Maiero

Previous by Thread:

[Xen-devel] Re: xen: PV on HVM: support PV spinlocks, Josip Rodin

Next by Thread:

[Xen-devel] Migrated domUs hangs, Cédric Schieli

Indexes:

[Date] [Thread] [Top] [All Lists]