WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Patch] update cpumask handling for cpu pools in lib

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Patch] update cpumask handling for cpu pools in libxc and python [and 1 more messages]
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 21 Sep 2010 16:04:31 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 21 Sep 2010 08:05:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C9332EA.3030006@xxxxxxxxxxxxxx>, <4C983A51.5000105@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4C9301DB.4050009@xxxxxxxxxxxxxx> <1284714037.16095.3083.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C9332EA.3030006@xxxxxxxxxxxxxx> <1284716674.16095.3180.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C933D1B.3040308@xxxxxxxxxxxxxx> <1284718257.16095.3217.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C934619.1000807@xxxxxxxxxxxxxx> <1284720423.16095.3257.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C9348BA.4000705@xxxxxxxxxxxxxx> <1284723441.16095.3355.camel@xxxxxxxxxxxxxxxxxxxxxx> <19603.39418.809534.435478@xxxxxxxxxxxxxxxxxxxxxxxx> <4C96EC80.4000901@xxxxxxxxxxxxxx> <19607.34717.433923.486852@xxxxxxxxxxxxxxxxxxxxxxxx> <4C983A51.5000105@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Juergen Gross writes ("Re: [Xen-devel] Re: [Patch] update cpumask handling for 
cpu pools in libxc and python"):
> On 09/20/10 18:11, Ian Jackson wrote:
> > The cpumask one still seems to assume little-endian, doesn't it ?
> 
> No, I don't think so.
> The hypervisor is using byte arrays for cpumasks in its interface to the
> tools. There bitmap_byte_to_64() is being used to convert it to uint64_t
> arrays.

Ah, OK.

> The main reason to change cpumask representation in the tools to a byte array
> (which I will do soon in another patch) is to avoid extra allocation of a
> buffer for the interface to the hypervisor.

OK.

However, I haven't applied your patch because it breaks the libxl
build.  You need to fix up all callers of xc_cpupool_getinfo
(libxl.c:622 and perhaps elsewhere).

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel