答复： Re: [Xen-devel][PATCH]ioemu: fix altgr-insert behavior

["Chun Yan Liu" <cyliu@xxxxxxxxxx>]

Thank you, Ian. The complete patch description:

 

When access to a Xen DomU (Linux) from a VNC client in Windows, alt-gr key is not working properly with Spanish keyboard. When Alt + another key pressed, vncserver receives Altgr down, Altgr up and key down messages in order, that causes incorrect output.

 

With following patch, when vncerver receives key down message, it first check if the keysym needs altgr modifer, if it needs altgr modifier but altgr is not 'down', sending altgr keycode before sending key keycode. 

 

Signed-off-by: Chunyan Liu <cyliu@xxxxxxxxxx>

 

Thanks,

Chunyan

>>> Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> 2010/9/11 1:42 >>>
Chun Yan Liu writes ("[Xen-devel][PATCH]ioemu: fix altgr-insert behavior"):
> Ian, attachment is the patch, the same as I've sent in previous
> mail. I don't know if you've received it before, so I send it
> again. Please have a review, thanks.

Thanks.  I've taken a look and I'll apply it but I need a
Signed-Off-By.

You do it like this:
   Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
except with your name and email address.  This indicates that you are
certifying the code as suitable (copyright-wise and so on) for
inclusion in Xen.  You can find the precise meaning in the Linux
upstream kernel tree (Documentation/SubmittingPatches, copy below).

Thanks,
Ian.

>From Documentation/SubmittingPatches:

       Developer's Certificate of Origin 1.1

       By making a contribution to this project, I certify that:

       (a) The contribution was created in whole or in part by me and I
           have the right to submit it under the open source license
           indicated in the file; or

       (b) The contribution is based upon previous work that, to the best
           of my knowledge, is covered under an appropriate open source
           license and I have the right under that license to submit that
           work with modifications, whether created in whole or in part
           by me, under the same open source license (unless I am
           permitted to submit under a different license), as indicated
           in the file; or

       (c) The contribution was provided directly to me by some other
           person who certified (a), (b) or (c) and I have not modified
           it.

       (d) I understand and agree that this project and the contribution
           are public and that a record of the contribution (including all
           personal information I submit with it, including my sign-off) is
           maintained indefinitely and may be redistributed consistent with
           this project or the open source license(s) involved.

--

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel