WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] libxl: make libxl communicate with xenstored by

To: "Jun Zhu (Intern)" <Jun.Zhu@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] libxl: make libxl communicate with xenstored by socket or xenbus driver-V3
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 10 Sep 2010 18:28:50 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 10 Sep 2010 10:29:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <433DDF91DFB08148BAD3FDB6FDDA314C9F35F3BB64@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <433DDF91DFB08148BAD3FDB6FDDA314C9F35F3BB64@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Jun Zhu (Intern) writes ("RE: [Xen-devel] [PATCH] libxl: make libxl communicate 
with xenstored by socket or xenbus driver-V3"):
> make libxl communicate with xenstored by socket or xenbus driver-version 3
> signed-off-by: Jun Zhu <Jun.Zhu@xxxxxxxxxx>

Thanks.  This doesn't apply to current xen-unstable staging, I'm
afraid.

Also:

> +    if (!xsh)
> +        fprintf(stderr, "cannot connect to xenstore");

This should use the logging functions provided, not just write to
stderr.

Finally:

> From: Ian Jackson
> Sent: 09 September 2010 13:09
> To: Jun Zhu (Intern)
> Cc: Ian Campbell; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: RE: [Xen-devel] [PATCH] libxl: make libxl communicate with xenstored 
> by socket or xenbus driver
> 
> [quoted message]

There is no need to paste the previous message in the thread onto the
bottom of your mail.  Indeed doing so can cause confusion if it has
extra bits of patch in it.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>