WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [PATCH,v2]: xl: don't free string literals

from [Ian Campbell] [Permanent Link][Original]
To: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH,v2]: xl: don't free string literals
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 8 Sep 2010 17:46:41 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Wed, 08 Sep 2010 09:47:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1283963489.20276.180.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1283963489.20276.180.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
On Wed, 2010-09-08 at 17:31 +0100, Gianni Tedesco wrote:
> 
>          /* then process config related to dm */
> -        if (!xlu_cfg_get_string (config, "device_model", &buf))
> -            dm_info->device_model = strdup(buf);
> +        !xlu_cfg_replace_string (config, "device_model",
> &dm_info->device_model); 

Stray ! at the start of the new line?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] Checkpointing for HVM guest with PV driver, Brendan Cully
Next by Date:  Re: [Xen-devel] [PATCH,v2]: xl: don't free string literals, Ian Campbell
Previous by Thread:  [Xen-devel] [PATCH,v2]: xl: don't free string literals, Gianni Tedesco
Next by Thread:  Re: [Xen-devel] [PATCH,v2]: xl: don't free string literals, Gianni Tedesco
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy