WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] libxc: restore: reset I/O fd to flags to back to sta

To: Ian Campbell <ian.campbell@xxxxxxxxxx>
Subject: [Xen-devel] [PATCH] libxc: restore: reset I/O fd to flags to back to state caller passed us
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 7 Sep 2010 19:07:27 +0100
Cc: Brendan Cully <brendan@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 07 Sep 2010 11:08:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f23b8e767b18bbeb867e.1283530032@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <f23b8e767b18bbeb867e.1283530032@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Ian Campbell writes ("[Xen-devel] [PATCH] libxc: restore: reset I/O fd to flags 
to back to state caller passed us"):
> libxc: restore: reset I/O fd to flags to back to state caller passed us
> 
> In particular this causes us to turn O_NONBLOCK back off if we set it.

This one doesn't apply any more.  This hunk:

> -        {
> -            if ( (flags = fcntl(io_fd, F_GETFL,0)) < 0 )
> -                flags = 0;
> -            fcntl(io_fd, F_SETFL, flags | O_NONBLOCK);
> -        }
> +            fcntl(io_fd, F_SETFL, orig_io_fd_flags | O_NONBLOCK);

seems to have become stale.  Have I applied these in the wrong order
or something ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel