WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Fix bind_irq_vector() destination

To: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Fix bind_irq_vector() destination
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 26 Aug 2010 10:22:29 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 26 Aug 2010 02:23:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201008261714.54218.sheng@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActE/z6jB++8PTSjRTSQC3gua6cKJwAAPWoS
Thread-topic: [Xen-devel] Fix bind_irq_vector() destination
User-agent: Microsoft-Entourage/12.26.0.100708
By the way, could an IRQ's 'domain' be given a better name in Xen? We
already have a meaning for domain, and it makes the code very confusing! Can
we call it cpu_affinity or cpu_binding, or something a bit more meaningful
and distinguishable?

 -- Keir

On 26/08/2010 10:14, "Sheng Yang" <sheng@xxxxxxxxxxxxxxx> wrote:

> The "mask" covered all online cpus in the "domain". It should be used as
> destination later, instead of using "domain" directly.
> 
> Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
> 
> --
> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -86,14 +86,14 @@
>      cpus_and(mask, domain, cpu_online_map);
>      if (cpus_empty(mask))
>          return -EINVAL;
> -    if ((cfg->vector == vector) && cpus_equal(cfg->domain, domain))
> +    if ((cfg->vector == vector) && cpus_equal(cfg->domain, mask))
>          return 0;
>      if (cfg->vector != IRQ_VECTOR_UNASSIGNED)
>          return -EBUSY;
>      for_each_cpu_mask(cpu, mask)
>          per_cpu(vector_irq, cpu)[vector] = irq;
>      cfg->vector = vector;
> -    cfg->domain = domain;
> +    cfg->domain = mask;
>      irq_status[irq] = IRQ_USED;
>      if (IO_APIC_IRQ(irq))
>          irq_vector[irq] = vector;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>