 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] libxc: make unlock_page return error
| To: | Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] libxc: make unlock_page return error |
| From: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
| Date: | Thu, 19 Aug 2010 15:46:19 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 19 Aug 2010 07:47:07 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <201008181642.10467.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Newsgroups: | chiark.mail.xen.devel |
| References: | <201008181642.10467.Christoph.Egger@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Christoph Egger writes ("[Xen-devel] [PATCH] libxc: make unlock_page return
error"):
> As a result of debugging 'xend segfaults when starting',
> the attached patch makes unlock_pages return an error.
Having read this in more detail, it seems that you're making
{lock,unlock}_pages return errno values on error. That's fine but
it's quite unusual in libxc; all libxc functions normally return -1 on
error and set errno.
So I think the unusual return value convention is worth a comment in
xc_private.h. Can you please resubmit with such a comment ?
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] libxc: make unlock_page return error, Ian Jackson |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] timer.c: Cast time value so that it has the correct type, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH] libxc: make unlock_page return error, Ian Jackson |
| Next by Thread: | Re: [Xen-devel] [PATCH] libxc: make unlock_page return error, Ian Campbell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
