WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools: Allow space in vbd path name

To: Jim Fehlig <jfehlig@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools: Allow space in vbd path name
From: Pasi Kärkkäinen <pasik@xxxxxx>
Date: Mon, 2 Aug 2010 21:57:14 +0300
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 02 Aug 2010 11:58:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BFC05C4.60708@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BFC05C4.60708@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, May 25, 2010 at 11:15:48AM -0600, Jim Fehlig wrote:
> Trivial fix for block script ...
> 

Hello,

was this patch merged? There's an user on ##xen complaining about
vif devices not released if there's a typo on the vbd path..

I think he tried both xen 4.0 and 4.1-unstable.

-- Pasi

> Regards,
> Jim
> 

> # HG changeset patch
> # User Jim Fehlig <jfehlig@xxxxxxxxxx>
> # Date 1274807602 21600
> # Node ID 14d040342c6618365750b2c3b96ca01ff4a5e5dd
> # Parent  93410e5e4ad8799932ad31820d0d82c74d1f63a2
> Allow space in vbd path name
> 
> c/s 20393 breaks existing domain configuration that contains
> spaces in the vbd path name.  Fixed by this trivial patch which
> provides missing quotes.
> 
>     Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>
> 
> diff -r 93410e5e4ad8 -r 14d040342c66 tools/hotplug/Linux/block
> --- a/tools/hotplug/Linux/block       Sat May 22 06:36:41 2010 +0100
> +++ b/tools/hotplug/Linux/block       Tue May 25 11:13:22 2010 -0600
> @@ -272,8 +272,8 @@
>  
>          if [ "x$mode" != 'x!' ]
>          then
> -          inode=$(stat -c '%i' $file)
> -          dev=$(stat -c '%D' $file)
> +          inode=$(stat -c '%i' "$file")
> +          dev=$(stat -c '%D' "$file")
>            if [ -z "$inode" ] || [ -z "$dev" ]
>            then
>              fatal "Unable to lookup $file: dev: $dev inode: $inode"

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>