WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] correct order of linker options to avoid link er

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] correct order of linker options to avoid link errors with recent toolchains
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 23 Jul 2010 17:57:22 +0100
Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 23 Jul 2010 09:58:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C86F87AF.1B6C9%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <19529.50929.327564.314930@xxxxxxxxxxxxxxxxxxxxxxxx> <C86F87AF.1B6C9%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Keir Fraser writes ("Re: [Xen-devel] [PATCH] correct order of linker options to 
avoid link errors with recent toolchains"):
> On 23/07/2010 17:44, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> >>  libxenguest.so.$(MAJOR).$(MINOR): LDFLAGS += $(call zlib-options,l)
> > 
> > What is this program "zlib-options" ?  I don't have it on my system.
> 
> It's right there in the same Makefile directly above the line you quoted.
> Yes, the above line can add -l<lib> items to LDFLAGS.

Oh, duh.  I'm confusing $(call ...) with $(shell ...) so I looked in
entirely the wrong place.

>  Sounds like the right fix would indeed be to define a new
> COMPRESSION_LIBS variable and put it at the end of the linker
> command line.

Yes.  Olaf, would you like to provide a patch to do that ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel