WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] hg ignore libxl lex/yacc detritus

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] hg ignore libxl lex/yacc detritus
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 16 Jul 2010 17:50:53 +0100
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 16 Jul 2010 09:51:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1be65436-b363-4862-a3f4-e55a997014fb@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcslBS+yQi4qPzywQFGurB1ZGYEQbwAAd233
Thread-topic: [Xen-devel] [PATCH] hg ignore libxl lex/yacc detritus
User-agent: Microsoft-Entourage/12.24.0.100205
Changeset 21000 checked those files into the tree, so adding them to
.hgignore would be very bad form. I've missed checking in bits of patches
due to that before.

If they are getting modified (i.e., regenerated) as part of your build then
that is a bug. Possibly the rules to generate them should be commented out
in the checked-in Makefile in that case... Whatever, I leave it to Stefano
and Ian to make a decision on that. But the right patch won't touch
.hgignore.

 -- Keir

On 16/07/2010 17:34, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> Please apply (this or some cleaner variation) to
> xen-unstable and xen-4.0-testing so that hg diff
> is clean after a build.
> 
> diff -r 57859775f88f .hgignore
> --- a/.hgignore Fri Jul 09 12:44:53 2010 +0100
> +++ b/.hgignore Fri Jul 16 10:24:02 2010 -0600
> @@ -317,3 +317,5 @@
>  ^unmodified_drivers/linux-2.6/.*\.ko$
>  ^unmodified_drivers/linux-2.6/.*\.mod\.c$
>  ^LibVNCServer.*
> +^tools/libxl/libxlu_cfg_l\.h$
> +^tools/libxl/libxlu_cfg_y\.h$
> +^tools/libxl/libxlu_cfg_l\.c$
> +^tools/libxl/libxlu_cfg_y\.c$



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel