Re: [Xen-devel] [PATCH] Don't attach needless options when launch pygrub

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Wed, 2010-07-14 at 11:07 +0100, Yu Zhiguo wrote:
> 
>  Oh, yes. It seems that path of specified 'kernel' will be checked 
> in configure_image(). We can delete this check if 'bootloader' is
> existent.

That's only for kernel specified on the xm command line, not from the
configuration file, isn't it?

I just confirmed that for a guest with grub configuration entries for
2.6.32-5-686-bigmem and 2.6.26-2-686-bigmem (in that order) then

        bootloader = "/usr/bin/pygrub"
        bootloader_args = "--quiet"
        
        kernel = "/boot/vmlinuz-2.6.26-2-686-bigmem"
        ramdisk = "/boot/initrd.img-2.6.26-2-686-bigmem"
        
will boot 2.6.26-2-686-bigmem whereas without the kernel and ramdisk
lines it will boot 2.6.32-5-686-bigmem.

>  What's your opinion?

This is long standing behaviour of the toolstack and although it's a
little odd it's not totally useless (it could be very useful if you
botch you grub configuration for example).

I'll ask again, what do you think is wrong with the current behaviour
and what are the benefits to changing it?

Ian.





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel