WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Dont' round-robin the callback interrupt

To: Paul Durrant <paul.durrant@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Dont' round-robin the callback interrupt
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 12 Jul 2010 17:05:51 +0100
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Delivery-date: Mon, 12 Jul 2010 09:08:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <0f3d7e651362dfe76a98.1278949935@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acsh2l51nUJdh1UOQtW3725Fv+EghQAAbrFI
Thread-topic: [Xen-devel] [PATCH] Dont' round-robin the callback interrupt
User-agent: Microsoft-Entourage/12.24.0.100205
On 12/07/2010 16:52, "Paul Durrant" <paul.durrant@xxxxxxxxxx> wrote:

> Dont' round-robin the callback interrupt.
> 
> Arrange that the event channel callback interrupt always goes to the
> lowest vcpu with a matching local apic. This should, in most cases,
> be VCPU0 (to which all event channels are bound for HVM guests) but
> this cannot be guaranteed.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> CC: Tim Deegan <tim.deegan@xxxxxxxxxx>

PV drivers should be handling callback on CPU != 0. The example Linux PV
drivers have done that for a very long time indeed. If a workaround is
needed for broken drivers then we need some way to gate it, and we should in
that case force delivery to VCPU0, as we do for some timer interrupts. The
forcing appears to do no harm even if not architecturally correct, and after
all we would be going to these lengths only because delivery to VCPU-not-0
*certainly* doesn't work.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel