WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xen: allow HVM save/restore from different changeset

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] xen: allow HVM save/restore from different changesets
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Thu, 8 Jul 2010 12:19:00 +0100
Delivery-date: Thu, 08 Jul 2010 04:20:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
Allow HVM save/restore from different changesets of Xen.  
The HVM save records are supposed to be backwards compatible; XenServer
live-migrates between versions of Xen during upgrades.

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>

diff -r 281896d3343a xen/common/hvm/save.c
--- a/xen/common/hvm/save.c     Thu Jul 08 12:07:16 2010 +0100
+++ b/xen/common/hvm/save.c     Thu Jul 08 12:10:59 2010 +0100
@@ -184,8 +184,6 @@
 
 int hvm_load(struct domain *d, hvm_domain_context_t *h)
 {
-    char *c;
-    uint64_t cset;
     struct hvm_save_header hdr;
     struct hvm_save_descriptor *desc;
     hvm_load_handler handler;
@@ -200,21 +198,6 @@
 
     if ( arch_hvm_load(d, &hdr) )
         return -1;
-
-    c = strrchr(xen_changeset(), ':');
-    if ( hdr.changeset == -1ULL )
-        gdprintk(XENLOG_WARNING, 
-                 "HVM restore: Xen changeset was not saved.\n");
-    else if ( c == NULL )
-        gdprintk(XENLOG_WARNING, 
-                 "HVM restore: Xen changeset is not available.\n");
-    else
-    {
-        cset = simple_strtoll(c, NULL, 16);
-        if ( hdr.changeset != cset )
-        gdprintk(XENLOG_WARNING, "HVM restore: saved Xen changeset (%#"PRIx64
-                 ") does not match host (%#"PRIx64").\n", hdr.changeset, cset);
-    }
 
     /* Down all the vcpus: we only re-enable the ones that had state saved. */
     for_each_vcpu(d, v) 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] xen: allow HVM save/restore from different changesets, Tim Deegan <=