xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] x86/cpufreq: check array index before use

from [Jan Beulich]

[Permanent Link][Original]

To:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] x86/cpufreq: check array index before use
From:	"Jan Beulich" <JBeulich@xxxxxxxxxx>
Date:	Tue, 06 Jul 2010 16:51:45 +0100
Delivery-date:	Tue, 06 Jul 2010 08:54:50 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

... rather than after.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- 2010-06-15.orig/xen/arch/x86/acpi/cpufreq/cpufreq.c 2010-07-06 
16:08:59.000000000 +0200
+++ 2010-06-15/xen/arch/x86/acpi/cpufreq/cpufreq.c      2010-07-06 
16:11:48.000000000 +0200
@@ -210,9 +210,11 @@ static u32 get_cur_val(cpumask_t mask)
 
     if (!cpu_isset(cpu, mask))
         cpu = first_cpu(mask);
-    policy = cpufreq_cpu_policy[cpu];
+    if (cpu >= NR_CPUS)
+        return 0;
 
-    if (cpu >= NR_CPUS || !policy || !drv_data[policy->cpu])
+    policy = cpufreq_cpu_policy[cpu];
+    if (!policy || !drv_data[policy->cpu])
         return 0;    
 
     switch (drv_data[policy->cpu]->cpu_feature) {

x86-cpufreq-cpu-check.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86/cpufreq: check array index before use, Jan Beulich <=

Previous by Date:	Re: [Xen-devel] [PATCH]: as requested, disable_migrate support for libxl, Keir Fraser
Next by Date:	[Xen-devel] [PATCH] x86/mce: use cpu_online() instead of cpu_isset(, cpu_online_map), Jan Beulich
Previous by Thread:	[Xen-devel] [PATCH] x86: eliminate unused "quad_local_to_mp_bus_id", Jan Beulich
Next by Thread:	[Xen-devel] [PATCH] x86/mce: use cpu_online() instead of cpu_isset(, cpu_online_map), Jan Beulich
Indexes:	[Date] [Thread] [Top] [All Lists]