WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] hotplug script: lock directory remains on error

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] hotplug script: lock directory remains on error
From: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
Date: Mon, 5 Jul 2010 10:21:18 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 04 Jul 2010 18:22:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19502.6886.128700.421247@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <7kd3v9xqq3.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> <19502.6886.128700.421247@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> > Adding sigerr is extra.
> 
> I'm not sure I follow this.  Why is this a good idea ?  Why not just
> say "exit 1" in the error handler in this script ?

Please see xen-hotplug-common.sh. Original (redefined) sigerr function
writes some error status to the xenstore.

On the other hand, the network-bridge script also includes locking.sh.
But sigerr function is not defined in it. Actually I met
"sh: sigerr: command not found" message on executing the network-bridge
script. Thus, I defined it in locking.sh, too.

Thanks,
Kouya

Ian Jackson writes:
> Kouya Shimura writes ("[Xen-devel] [PATCH] hotplug script: lock directory 
> remains on error"):
> > _release_lock should be used instead of release_lock.
> 
> That part is OK.
> 
> > Adding sigerr is extra.
> 
> I'm not sure I follow this.  Why is this a good idea ?  Why not just
> say "exit 1" in the error handler in this script ?
> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>