WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 10/13] Do not try to disable hpet if it hasn't be

To: stefano@xxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [PATCH 10/13] Do not try to disable hpet if it hasn't been initialized before
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Fri, 02 Jul 2010 12:44:55 +0200
Cc: jeremy@xxxxxxxx, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano.Stabellini@xxxxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, ddutile@xxxxxxxxxx, sheng@xxxxxxxxxxxxxxx
Delivery-date: Fri, 02 Jul 2010 04:04:14 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=Njw7bN2OvXTGgXGlOdrUCRRHPkiyd7sCwyivUBXRm5c=; b=w/pJ0qlBG2LKNcrop0MCKB2lo8zEgc9fXNoyR12Mb/XD1f3oH+cd1RMhbrQ/PQB8jq ZHnZl7xdkc/WZH31qsCDJSWtrHoli84BT8ZWg/GuUW6mtPuoQjmn+Z05a5s0ZV00YNM+ dd/oPD7QqrllzIUyDz081ouyT7/GB3Fxiyrak=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=LEqoF2plib4WF5T7KTfheG6eqdw5y+LY4mFUQp8MC+mp11wpcGxGtZ1ei77lkAWlSw DgHmBf3cBE+dts8+RTePVgPt50Q0/xlEUKDFV8aCzavvD+KmVLahwx6IDEQ3NXfoIFgz Lgjp9VLwfWLeW/j1KMSB+JvXyz1JYMfUweS0A=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1277136847-13266-10-git-send-email-stefano@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1006211456360.18470@kaball-desktop> <1277136847-13266-10-git-send-email-stefano@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5
On 06/21/2010 06:14 PM, stefano@xxxxxxxxxxxxxx wrote:
-       if (is_hpet_capable()) {
-               unsigned int cfg = hpet_readl(HPET_CFG);
+       unsigned int cfg;

You changed this earlier from unsigned long to unsigned int, but it is wrong (though it works because bits 32-63 of the HPET_CFG register are unused). Can you please make a note to change it back sometime?

Thanks,

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>