WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: fix an off-by-one pirq range check

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: fix an off-by-one pirq range check
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Thu, 1 Jul 2010 12:19:45 -0400
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 01 Jul 2010 09:22:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C2C5F7B0200007800008FE9@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C2B02460200007800008B83@xxxxxxxxxxxxxxxxxx> <20100630161641.GE5100@xxxxxxxxxxxxxxxxxxx> <4C2C5F7B0200007800008FE9@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-12-10)
On Thu, Jul 01, 2010 at 08:27:23AM +0100, Jan Beulich wrote:
> >>> On 30.06.10 at 18:16, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 
> >>> wrote:
> > On Wed, Jun 30, 2010 at 07:37:26AM +0100, Jan Beulich wrote:
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> > 
> > Won't that make PV guest with only one IRQ passed through unable to ACK it?
> > (and if the IRQ is not shared that is).
> 
> Why would you think so? In such a case, nr_pirqs would be 1, and the
> only permitted pirq would be 0. All other places do the range checks
> correctly, just this one would let through an out of bounds number.

Excellent. Thanks for the answer. 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>