WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86 cpu: use rdmsrl/wrmsrl

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86 cpu: use rdmsrl/wrmsrl
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 29 Jun 2010 13:28:11 +0100
Cc:
Delivery-date: Tue, 29 Jun 2010 05:30:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201006291037.31398.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcsXZowkH9+23uAHTmyZr04LrGS4rwAH/1bI
Thread-topic: [Xen-devel] [PATCH] x86 cpu: use rdmsrl/wrmsrl
User-agent: Microsoft-Entourage/12.24.0.100205
On 29/06/2010 09:37, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> 
> Hi!
> 
> Attached patch makes x86 cpu code use rdmsrl/wrmsrl and cleans up surrounding
> code.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

Half of these changes are definitely for the worse. Taking arguments that
are naturally split into two halves and then assembling them by hand just to
have them split again by wrmsrl does not make the code better. Touching
generally untested code like transmeta.c also just seems a bad idea.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>