WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/3] libflask merging in libxenctrl

To: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/3] libflask merging in libxenctrl
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Tue, 22 Jun 2010 10:50:03 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 22 Jun 2010 02:51:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1277198818-27090-1-git-send-email-vincent.hanquez@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1277198818-27090-1-git-send-email-vincent.hanquez@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
At 10:26 +0100 on 22 Jun (1277202415), Vincent Hanquez wrote:
> The following patch series fold libflask into libxenctrl.
> 
> The flask library is small, and putting everything in libxenctrl make
> relying on flask functionalities in libxl easier.

That doesn't sound like a good reason to duplicate a library to me.  
If libxl needs flask functions it should link against them.
Are you volunteering to maintain a fork of a security library?

Tim.

> libflask is left for compatibility purpose, but should be considered
> deprecated, and remove in the near future. all flask_ symbols are now
> xc_flask_ symbols in libxenctrl.
> 
> also remove some code duplication in the add_ and del_ calls.
> 
> Vincent Hanquez (3):
>   merge libflask into libxenctrl
>   remove some duplicated code by having helper add/del functions
>   add flask capabilities in python xc bindings
> 
>  tools/libxc/xc_flask.c            |  357 
> +++++++++++++++++++++++++++++++++++++
>  tools/libxc/xenctrl.h             |   26 +++
>  tools/python/xen/lowlevel/xc/xc.c |  251 ++++++++++++++++++++++++++
>  3 files changed, 634 insertions(+), 0 deletions(-)
> 

Content-Description: ATT00001..txt
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel