WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/1] Xen ARINC 653 Scheduler (updated to add sup

To: Kathy Hadley <Kathy.Hadley@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/1] Xen ARINC 653 Scheduler (updated to add support for CPU pools)
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Wed, 16 Jun 2010 16:50:14 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 16 Jun 2010 08:51:04 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=vLZU0Dn3Zr1gy+FK0azJXlGtibDn27zl5AqAvnLCKbo=; b=s8zpx7iFW8n7YogHQQQtL37w+zg2hjZL4eRhlTI96Tnas0wxSmLd8c4ScaMoPwqPlE SF5qE82lS72RCUtGgwdmf+P8SMnT9R6ge4gUG6xbbWyfYrgxCbcvWIupz+hd68ID9jM6 +P92hrVKZuqO6CYXGVUa7t7TaIcRgCbOY1UnQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=srq4OE2GUAxksYqRrKclZLOMlYgHcWmE80UzMdQCvMIiXwZ1gsawFAKbqHYE0rsS8c dmxaK1wPr0+kcHCZ7R5Nw1AMt8IIeTAuKG++5hrsBqOi3PxRcGCCz4ECP5xCHvYYs/+V //LMmpTtdSpSH06Cqyf9kl1T+IlT0nyezRTLs=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <D3E384327F5C6D48AADCEA84160B7D7301470EC7@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <D3E384327F5C6D48AADCEA84160B7D7301470EC7@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, Jun 16, 2010 at 4:04 PM, Kathy Hadley
<Kathy.Hadley@xxxxxxxxxxxxxxx> wrote:
> +/**************************************************************************
> + * Global data                                                            *
> +
> **************************************************************************/
> +static arinc653_sched_private_t arinc653_schedule;
[snip]
> +    /* Allocate memory for ARINC 653 scheduler data structure */
> +    prv = &arinc653_schedule;

You didn't actually allocate memory, you just used the static
structure.  The point of cpupools is to allow multiple instances of a
scheduler to coexist -- if people create two pools, both using the
ARINC scheduler, there will be problems with this.  Is there any
reason not to actually call xmalloc() (as is done in
sched_credit.c:csched_init())?  (Perhaps this is a missed FIXME or a
merge-o?)

Some of the notices in headers seems a little excessive; if
sched_arinc653.c credits Dornerworks, surely people can infer who
added the control structure in xen/include/public/sysctl.h, and added
a link to it in scheduler.c?

Not NACK-worthy, but: In struct arin..._sched_private_s, the element
"arinc653_schedule" should probably be named something a bit more
descriptive.  Similarly, having arinc653 in ..._major_frame seems a
bit redundant, and inconsistent with naming for the other elements.

Looks fine to me otherwise.  (I haven't reviewed the algorithm itself.)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel