|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
Re: [Xen-devel] [PATCH 02/12] early PV on HVM
 
| 
To:  | 
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> | 
 
| 
Subject:  | 
Re: [Xen-devel] [PATCH 02/12] early PV on HVM | 
 
| 
From:  | 
Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> | 
 
| 
Date:  | 
Tue, 8 Jun 2010 16:55:33 +0100 | 
 
| 
Cc:  | 
"jeremy@xxxxxxxx" <jeremy@xxxxxxxx>,	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>,	Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>,	"Yaozu \(Eddie\) Dong" <eddie.dong@xxxxxxxxx>,	"linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>,	"ddutile@xxxxxxxxxx" <ddutile@xxxxxxxxxx>,	"sheng@xxxxxxxxxxxxxxx" <sheng@xxxxxxxxxxxxxxx> | 
 
| 
Delivery-date:  | 
Tue, 08 Jun 2010 08:57:36 -0700 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<20100608134637.GA5998@xxxxxxxxxxxxxxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<1275570645-27189-1-git-send-email-stefano.stabellini@xxxxxxxxxxxxx>	<1275570645-27189-2-git-send-email-stefano.stabellini@xxxxxxxxxxxxx>	<20100604202008.GB17645@xxxxxxxxxxxxxxxxxxx>	<alpine.DEB.2.00.1006071518050.3401@kaball-desktop>	<20100608134637.GA5998@xxxxxxxxxxxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
| 
User-agent:  | 
Alpine 2.00 (DEB 1167 2008-08-23) | 
 
 
 
On Tue, 8 Jun 2010, Konrad Rzeszutek Wilk wrote:
> > > > +       HYPERVISOR_shared_info = (struct shared_info *)shared_info_page;
> > > > +
> > > > +       /* Don't do the full vcpu_info placement stuff until we have a
> > > > +          possible map and a non-dummy shared_info. */
> > > 
> > > Might want to mention where the full vpcu placement is done.
> > 
> > The comment is not accurate, we actually don't do any vcpu_info
> > placement on hvm because it is not very useful there.
> > Better just to remove the comment (I have done so in my tree).
> > 
> > > > +       per_cpu(xen_vcpu, 0) = &HYPERVISOR_shared_info->vcpu_info[0];
> > > 
> So.. what is the purpose of the per_cpu(xen_vcpu, 0) then?
> 
the vcpu info placement memory area is stored in per_cpu(xen_vcpu_info, cpu);
per_cpu(xen_vcpu, cpu) is just a pointer to that area if it is
available, otherwise it points to the vcpu_info struct in the shared
info page.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 
 |   
 
 | 
    | 
  
  
    |   | 
    |