Re: [Xen-devel] [PATCH][VTD] enable integrated graphics passthrough for Calpella and Sandybridge

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Thu, Jun 03, 2010 at 05:18:33PM -0700, Kay, Allen M wrote:
> Added Calpella and Sandybridge integrated graphics pass-through support,
> consolidated graphics pass-through code into pt-graphics.c.
> 
>  
> 
> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
>

Some minor comments.
pci_{read, write}_block() would be better than
switch(len) case 1: case 2: case4:...
Is it really necessary to move PCIBus and PCIBridge to the header file?
Doesn't pci_bridge_init() work?
Overriding pci config read/write methods of i440fx would be much cleaner
than hooking pci_data_read/write. (pass igd_pci_read/write to 
pci_register_device() in i440fx_init() in hw/piix_pci.c instead of NULL)
-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel