WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Null-pointer access in netback_uevent

To: "Jeremy Fitzhardinge" <jeremy@xxxxxxxx>, "Bastian Blank" <waldi@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] Null-pointer access in netback_uevent
From: "James Harper" <james.harper@xxxxxxxxxxxxxxxx>
Date: Sat, 29 May 2010 08:42:26 +1000
Cc:
Delivery-date: Fri, 28 May 2010 15:43:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BFFFD30.6000807@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100527165558.GA11358@xxxxxxxxxxxxxxxxxxxxxxx> <AEC6C66638C05B468B556EA548C1A77D01996BD8@trantor> <AEC6C66638C05B468B556EA548C1A77D01996BDB@trantor> <AEC6C66638C05B468B556EA548C1A77D01996BE0@trantor> <20100528090325.GA13575@xxxxxxxxxxxxxxxxxxxxxxx> <4BFFFD30.6000807@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acr+i0hrFMFQLKcwRLulArV8hWKsSwAK5z/w
Thread-topic: [Xen-devel] Null-pointer access in netback_uevent
> > > Looking into this further, I suspect that the trigger here is a newer
> > > version of udev or something in that area. netback_uevent is getting 
> > > called
> > > before the call to netback_probe containing the call to dev_set_drvdata.
> > >
> > There are two problems there. And yes, the uevent routine can be called
> > at any time.
> >
> 
> So would it be correct for it to just return if either of those are
> NULL?

Not sure. It works though.

>  Will it get called again later once the device info is available?

It does get called again later when the device info has been populated. I'm not 
sure if we can count on that though.

James

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel