WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] libxl: build fix

from [Ian Jackson] [Permanent Link][Original]
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] libxl: build fix
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 27 May 2010 15:41:46 +0100
Delivery-date: Thu, 27 May 2010 07:42:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201005251136.18205.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <201005251136.18205.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
Christoph Egger writes ("[Xen-devel] libxl: build fix"):
> Attached patch makes libxl build again on NetBSD.
> 
> The build error is:
> warning: array subscript has type 'char'
> Note, that we compile libxl with -Werror

This patch is an improvement.  But the correct approach is to cast to
unsigned char, not uint8_t.  (In the context of Xen this doesn't
matter since our unsigned chars are all uint8_t anyway.)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] Name of event-channel and other devices vs. udev, Bastian Blank
Next by Date:  Re: [Xen-devel] [PATCH 04/11] Fix find_unbound_irq in presence of ioapic irqs., Stefano Stabellini
Previous by Thread:  [Xen-devel] libxl: build fix, Christoph Egger
Next by Thread:  [Xen-devel] Improving domU restore time, Rafal Wojtczuk
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy