WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xl: allow nameless domains to be named

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xl: allow nameless domains to be named
From: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
Date: Wed, 26 May 2010 08:45:53 +0800
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Vincent Hanquez <Vincent.Hanquez@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 25 May 2010 17:44:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BFC369A.7070100@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BFC369A.7070100@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100423 Thunderbird/3.0.4
Hi jeremy,

On 05/26/2010 04:44 AM, Jeremy Fitzhardinge wrote:
> At present, find_domain() will exit(2) if you specify a domain by
> number, but that domain doesn't have a corresponding name.  However,
> nothing seem to critically depend on common_domname being set, and the
> test prevents dom0 or other nameless domains from being named.  So just
> remove the check.

Thank you, for now, remove the check seems to be the solution.

> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>

Acked-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>

> 
> diff -r ba7fdd53f44c tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c        Tue May 25 13:37:20 2010 -0700
> +++ b/tools/libxl/xl_cmdimpl.c        Tue May 25 13:40:53 2010 -0700
> @@ -138,10 +138,6 @@
>          exit(2);
>      }
>      common_domname = was_name ? p : libxl_domid_to_name(&ctx, domid);
> -    if (!common_domname) {
> -        fprintf(stderr, "%s is an invalid domain identifier.\n", p);
> -        exit(2);
> -    }
>  }
>  
>  #define LOG(_f, _a...)   dolog(__FILE__, __LINE__, __func__, _f "\n", ##_a)
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 


-- 
Regards
Yang Hongyang

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>