WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [PATCH 2/2]xl: Add "xl top" command

from [Ian Jackson] [Permanent Link][Original]
To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/2]xl: Add "xl top" command
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 21 May 2010 11:29:06 +0100
Delivery-date: Fri, 21 May 2010 03:29:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BEA180D.5080107@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4BEA180D.5080107@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
Yang Hongyang writes ("[Xen-devel] [PATCH 2/2]xl: Add "xl top" command"):
> Add "xl top" command, a clone of "xm top".
> 
> Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>

This is mostly OK, but:

> +    system("xentop");

1. You should probably use execlp rather than system.
2. You do not check the return value.  This is a serious mistake.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] [PATCH 15/17] vmx: nest: virtual ept for nested, Qing He
Next by Date:  Re: [Xen-devel] [PATCH 08/17] vmx: nest: L1 <-> L2 context switch, Qing He
Previous by Thread:  [Xen-devel] [PATCH 2/2]xl: Add "xl top" command, Yang Hongyang
Next by Thread:  RE: [Xen-devel] XCP: source repo?, YAMAMOTO Takashi
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy