Re: [Xen-devel] [PATCH] compilation and other small fixes to libxl

[Yang Hongyang <yanghy@xxxxxxxxxxxxxx>]

On 05/19/2010 09:25 AM, Dulloor wrote:
> Patch fixes the following problems :
> 
> * Some of the library functions such as fscanf, system, and asprintf
> are declared with warn_unused_result (ubuntu server 9.10), causing
> compilation errors in libxl.
> * When using asprintf, the caller is responsible for freeing the memory.
> * memset takes wrong size argument in one of the places (caught by an
> a builtin gcc check).
> 
> -dulloor
> 
> Signed-off-by: Dulloor Rao <dulloor@xxxxxxxxx>
> 
> 

Acked-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx> 


-               domuid);
+    {
+        uptime_str = uptime_to_string(uptime, 1);
+               printf(" %s up %s, %s (%d)\n", current_time_to_string(now),

Here's an indent problem.

+                       uptime_str, libxl_domid_to_name(&ctx, domuid), domuid);
+    }
     else


> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


-- 
Regards
Yang Hongyang

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel