WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/2]xl: Check invalid domid in find_domain()

To: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/2]xl: Check invalid domid in find_domain()
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 18 May 2010 10:01:27 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 18 May 2010 10:02:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BF1EACF.30300@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BEBC822.6080009@xxxxxxxxxxxxxx> <4BF1D0F1.9020302@xxxxxxxx> <4BF1EACF.30300@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4
On 05/17/2010 06:18 PM, Yang Hongyang wrote:
> Hi jeremy,
>
> On 05/18/2010 07:27 AM, Jeremy Fitzhardinge wrote:
>   
>> On 05/13/2010 02:36 AM, Yang Hongyang wrote:
>>     
>>> If domain id is invalid, find_domain should return error because
>>> the specified domain does not exist.
>>>   
>>>       
>> I think this patch is causing some regressions.  For example, I can no
>> longer rename dom0:
>>
>> sh-4.0# xl list 0
>> Name                                        ID   Mem VCPUs   State   Time(s)
>> (null)                                       0  3321     4        r--    
>> 741.7
>> sh-4.0# xl rename 0 dom0
>> 0 is an invalid domain identifier.
>>
>> I haven't specifically worked out what's failing here...
>>     
> I think there's some other problems in the kernel or xl.

The kernel has nothing to do with domain management, so the problem must
either be in usermode or in Xen (but since Xen is known to work...).

>  First of all, the
> (null) name should not appera in the list, if there is, then this
> VM is not fullly destoried I think, but when I'm trying to destory the vm, 
> libxl
> reported errors and the VM still exists. Second of all, I notice that your
> DOM0's name is (null), and State is running, how could you do that? I manully
> tryed out 'xl rename "(null)"' to rename DOM0's name to (null), but after
> that I can still rename the name back with my patch.
>   

I boot my machine without ever having run xend.  When I first log in:

# oxenstored
# xl list
Name                                        ID   Mem VCPUs      State   Time(s)
(null)                                       0  3321     4        r--    143.1


But the problem is that "xl" doesn't let me operate on dom0 at all.  For
example, if I do:

# xl mem-set 0 2000000
0 is an invalid domain identifier.


> We often met the "(null)" problem's either, but never met that problem on 
> DOM0...
> And the "(null)" problem often happened after "xl destory". We can not
> figure out a method to reproduce this problem.
>   

I see this regularly, especially after doing a "xl save" on a domain.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>