Re: [Xen-devel] [PATCH] Allow PV superpages to work with live migration

[Dave McCracken <dcm@xxxxxxxx>]

On Tuesday, May 18, 2010, Tim Deegan wrote:
> > PV superpages currently do not work with live migration.  They fall over
> > dead  when the shadow page table is enabled for dirty tracking.  The HVM
> > support for superpages in this code has been tested and found to work
> > just fine for PV superpages.  This patch modifies the test macro to
> > allow the code to work with PV superpages.
> 
> It rather overshoots. :)  This enables PSE even for HVM guests which
> have explicitly disabled it.   I think you want
> 
>     return (is_hvm_vcpu(v) ? (GUEST_PAGING_LEVELS != 2
>                               || !hvm_paging_enabled(v)
>                               || (v->arch.hvm_vcpu.guest_cr[4] &
> X86_CR4_PSE)) : opt_allow_hugepage);

I'm confused.  As far as I know, opt_allow_hugeage only affects PV guests.  All 
I did in the macro was add a test for it.  I didn't touch any of the HVM 
logic.  Are you saying the HVM logic is wrong or that opt_allow_hugepage 
affects HVM guests in some fashion?

Dave McCracken
Oracle Corp.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel