WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Add MSR support for new AMD processor families

To: "Mark Langsdorf" <mark.langsdorf@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Add MSR support for new AMD processor families
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Mon, 17 May 2010 09:32:55 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 17 May 2010 01:33:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201005141419.02047.mark.langsdorf@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201005141419.02047.mark.langsdorf@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Mark Langsdorf <mark.langsdorf@xxxxxxx> 14.05.10 21:19 >>>
>@@ -500,7 +499,7 @@
> #endif
> 
>       /* Pointless to use MWAIT on Family10 as it does not deep sleep. */
>-      if (c->x86 == 0x10 && !force_mwait)
>+      if (c->x86 >= 0x10 && !force_mwait)
>               clear_bit(X86_FEATURE_MWAIT, c->x86_capability);
> 
>       /* K6s reports MCEs but don't actually have all the MSRs */

Is this indeed the right thing to do on *all* processors starting
with Fam10?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>