WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xend: update init script to avoid grep on non-ex

To: Richie <listmail@xxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xend: update init script to avoid grep on non-existent file system
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Sat, 15 May 2010 08:35:45 +0100
Cc:
Delivery-date: Sat, 15 May 2010 00:36:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BEE2008.7020808@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acrz5XZu7B1W0G70TNO6k5VS8cRb9wAG8Q8r
Thread-topic: [Xen-devel] [PATCH] xend: update init script to avoid grep on non-existent file system
User-agent: Microsoft-Entourage/12.24.0.100205
On 15/05/2010 05:16, "Richie" <listmail@xxxxxxxxxxxx> wrote:

> I'm seeing a grep error during bare metal pvops kernel boot.  In the
> init script, the previous checks will avoid/perform the /proc/xen mount
> as appropriate, but then it does a grep on /proc/xen/capabilities
> without ensuring that /proc/xen is actually mounted.  This is my attempt
> (read: first patch :) ) to avoid it.

Richie,

Can you try adding the -s option to grep instead (i.e., grep -qs)? Should be
a simpler way to achieve the same thing. I'll apply that instead if it works
okay for you.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel